jancborchardt / hyperminimal

:zap: Hyper terminal extension to remove window header
https://www.npmjs.com/package/hyperminimal
MIT License
78 stars 8 forks source link

Does not work with some themes #8

Open rmurai0610 opened 7 years ago

rmurai0610 commented 7 years ago

Some themes forces header to be added in causing first few line to be hidden behind it (At least on OS X) (For example hyper-ayu)

screen shot 2016-12-27 at 12 19 16

One way to solve this would be to set .header_header { display: none } When there is only one tab open, but this prevents OS X user from being able to move the window. There is a dirty way of solving this which would be to set .header_header { background: rgba(0, 0, 0, 0.0) !important} Which will keep the header (so its still draggable in OS X) and prevents first few line from getting hidden.

jancborchardt commented 7 years ago

but this prevents OS X user from being able to move the window

The whole point of this extension is to show no header row at all. :) On Ubuntu & Elementary at least moving the window can be done via Super / Windows key and then dragging the window anywhere as mentioned in https://github.com/jancborchardt/hyperminimal/issues/7 Does that also work on macOS with the Cmd or Ctrl keys maybe?

rmurai0610 commented 7 years ago

Unfortunately using Cmd /Ctrl key doesn't seem to work with OS X.

jancborchardt commented 7 years ago

Hm, does using Alt or this answer help maybe? http://apple.stackexchange.com/a/114794

rmurai0610 commented 7 years ago

Unfortunately, it still does not work. It seems like the issue is that nav is defined to be the draggable region and setting header_header to none seems to make nav section un-clickable. https://github.com/zeit/hyper/blob/12ae25a60b800efdd19205a0f259bd53c1668273/lib/components/tabs.js#L81

net commented 7 years ago

To move windows on macOS without a title bar hover over the edge of a window so the resize arrow appears, then drag perpendicular to the direction of the resize arrow. For example, when hovering over the left or right edge, drag vertically instead of horizontally.

rmurai0610 commented 7 years ago

@net Thanks! I didn't know that you can move windows this way.

jancborchardt commented 7 years ago

Awesome, thanks @net! :) Do you want to add that to the »How to use« section of the readme at https://github.com/jancborchardt/hyperminimal#how-to-use via pull request?

jancborchardt commented 7 years ago

And @rmurai0610 if that solution works for dragging, can you maybe add a force override for those themes so the header is also hidden then? (Since you have macOS.) Maybe it’s even just an !important to the CSS rule. :)

net commented 7 years ago

9

jancborchardt commented 7 years ago

@rmurai0610 @net does someone of you also want to submit a pull request to fix the header being inserted due to some themes again? :)