janczizikow / sleek

:chart_with_upwards_trend: Sleek is a modern Jekyll theme focused on speed performance & SEO best practices
https://janczizikow.github.io/sleek/
MIT License
423 stars 638 forks source link

Update Gulp to 4.0.0 #54

Closed lachieh closed 6 years ago

lachieh commented 6 years ago

This PR does a couple of things surrounding the upgrade to Gulp 4.0. This PR closes #52.

I'm happy to continue optimizing, or to pull back and limit these changes a little. One thing to note is that the clean, sw and critical tasks all run with the default task now, whereas they had tobe run individually before. Even with these additions, the gulp parallel method means that it still runs just as fast (~8s before to ~5s now)

Further improvements could be splitting the gulpfile into a folder with modules and includes. (i.e. gulpfile.babel.js/index.js)

janczizikow commented 6 years ago

Hey @lachieh ,

Thanks a lot for this, this is great! 🎉

If you would be interested in splitting the gulpfile into separate modules, as you mentioned, just feel free to make a PR 🙂