fetch: urllib confused by "git@git.my.provider.com" fetch-url

GoogleCodeExporter commented 8 years ago

Affected Version: all?
Environment: Debian testing

What steps will reproduce the problem?
1. use "<remote name="myname" fetch="git@git.my.provider.com/subdir"/>" in 
manifest
2. do a "repo sync"

Does not work, invalid URL is passed to git.

The line 106 in manifest_xml.py causes the problem by "urljoin"ing the 
"manifestUrl" and "url" in "urllib". The attached patch adds a debug-print at 
the corresponding place. Uncommenting the urljoin makes everything work...

Original issue reported on code.google.com by sfthsrth...@gmail.com on 1 Sep 2014 at 2:01

Attachments:

0001-add-debug-print-for-urljoin-bug.patch

GoogleCodeExporter commented 8 years ago

Digging further. this looks like a combination of git guessing the "ssh" scheme 
correctly and urllib not doing so. however, using a explicit line like "<remote 
name="myname" fetch="ssh://git@git.my.provider.com/subdir"/>" works fine.

So no real bug, just an inconvenience

Original comment by sfthsrth...@gmail.com on 3 Sep 2014 at 8:57

GoogleCodeExporter commented 8 years ago

As noted in issue #166, comment #1, git@git.my.provider.com is not an url.

https://code.google.com/p/git-repo/issues/detail?id=166#c1

Original comment by yann@droneaud.fr on 29 May 2015 at 7:57

jandc3845 / git-repo

fetch: urllib confused by "git@git.my.provider.com" fetch-url #180