search

jandelgado / gcov2lcov-action

Github action to convert go coverage files to lcov format
MIT License
22 stars 2 forks source link

Why not use precompiled binary? #5

Closed septs closed 4 years ago

septs commented 4 years ago

image

like https://github.com/golangci/golangci-lint-action

from https://github.com/linxGnu/gosmpp/runs/1140698513

jandelgado commented 4 years ago

I'm not sure why you proposing the change. Is it to make sure that the correct version of gcov2lcov is used?

septs commented 4 years ago

gh-actions run docker very slower.

septs commented 4 years ago

gh-actions per run job will build docker image.

the a process need ≈ 20s to 30s

direct use precompiled binary, in gh-actions expected in 5s.

jandelgado commented 4 years ago

implemented with release 1.0.4

jandelgado commented 4 years ago

can we close the issue, @septs ?

septs commented 4 years ago

why docker based?

jandelgado commented 4 years ago

gcov2lcov needs installed go tooling available. Therefore a container. Feel free to Open a MR for further improvents - thanks