search

jandelgado / jled

Non-blocking LED controlling library for Arduino and friends.
MIT License
324 stars 51 forks source link

Minimum brightness #99

Closed Welsyntoffie closed 1 year ago

Welsyntoffie commented 1 year ago

I am not finding any references to minimum brightness for the breathing effect. Currently LED's turn off then fades on again. I would like to set a minimum brightness. Is that possible?

jandelgado commented 1 year ago

Not yet, will add the feature soon.

Welsyntoffie commented 1 year ago

Thats great news, thank you.

sauresahne commented 1 year ago

Just stumbled upon this through Hackaday, Wonderful library, thanks. That enhancement sounds great. I am going to use it for a bike light.

To summarize the great-rear-light-blinking-debate:
Opinion 1: A blinking rear light gives you more attention from other drivers. Opinion 2: A steady rear light helps other people in judging distance and your speed. Blinking interferes with that. If a blinking light is your only rear light, other drivers can see you, but not always locate you precisely.

So, yeah. Being able to set a constant led brightness with a blink or breath on top would be really great.

jandelgado commented 1 year ago

Released with 4.12.0 https://github.com/jandelgado/jled/releases/tag/v4.12.0

Welsyntoffie commented 1 year ago

Works great. Thank you. I did notice that the stop command does not turn the led off but keeps it at the lowest set brightness. In my project I had to analogwrite=0 to completely turn off the led. But the MinBrightness does work great. Closing this issue

jandelgado commented 1 year ago

Good Point. Will think about it over the holidays. I think it would still be good to be able to turn a LED fully off with Stop, perhaps by adding an optional parameter.

jandelgado commented 10 months ago

fyi @Welsyntoffie: with JLed Release 4.13.0 (see #121 ) it is now possible to fully turn of the LED or keep the last value with Stop().

Welsyntoffie commented 10 months ago

Great. Thanks for info. Still going strong with my CSGO stage light strip.