search

jandony / react-workout

Collaborative react workout project
3 stars 0 forks source link

Refactor how the sidebar navigates to the results page #18

Closed AvatarGreggles closed 4 years ago

AvatarGreggles commented 4 years ago

Maybe in the map function which returns the sidebar elements, we can wrap them in a Link? I tried but I then had to import the Router which got a bit messy.

jandony commented 4 years ago

I am going to include Restyling the sidebar to this Issue, because it's all the same component. I was thinking we could use a hamburger menu to open / close the sidebar. Only because it is impacting the muscle group cards on the page.

jandony commented 4 years ago

I would say this is done. Would you agree?

If you didn't see, I was able to play around with the dynamic routing. So instead of the url saying localhost:3000/results it it will now say localhost:3000/musclegroup (localhost:3000/neck or localhost:3000/abs)

AvatarGreggles commented 4 years ago

Nice one! I actually asked a question in the PR about the routing, so maybe this answers it. But lets discuss in Slack, I'm eager to learn how it was done :)