search

jandrew / Spreadsheet-XLSX-Reader-LibXML

Read spreadsheet files with xlsx extentions
Other
4 stars 2 forks source link

Serious trouble under perl-5.24.0 (64bitall longdouble threaded) #100

Open Tux opened 8 years ago

Tux commented 8 years ago

https://gist.github.com/Tux/47528e1ff68ee4d7caacab6815b9573b

both from CPAN and from git checkout

Tux commented 8 years ago

Same for perl 5, version 22, subversion 1 (v5.22.1) built for x86_64-linux-thread-multi-ld and perl 5, version 22, subversion 0 (v5.22.0) built for x86_64-linux-thread-multi-ld

jandrew commented 8 years ago

This and several other problems have been occurring with this package. I appealed to the monks and worked on the problem myself for a time and was unable to solve the largest of the problems. The test suite is now failing across the board . I have released a new package (Spreadsheet::Reader::ExcelXML) that solves these problems by removing XML::LibXML. I have also put a Deprecation warning at the top of this package. It is with sadness that I am throwing in the towel. On the upside I open the package to co-maintainership in PAUSE and would be open to completely giving it over.

mauke commented 8 years ago

There are some double frees going on. The failing/crashing free seems to happen during global destruction inside xmlFreeTextReader (called from XML::LibXML::Reader->DESTROY).

jandrew commented 8 years ago

I did see that and initially I was concerned with Moose::XS. I rewrote the whole top level to force all the perl garbage collection to happen when the instance went out of scope rather than when the script exited since the top level holds a recursive reference to itself. However this didn't solve the problem. I did find that removing the XML::LibXML requirement did. Please let me know if https://metacpan.org/pod/Spreadsheet::Reader::ExcelXML doesn't resolve the problem for you.