search

jandrew / Spreadsheet-XLSX-Reader-LibXML

Read spreadsheet files with xlsx extentions
Other
4 stars 2 forks source link

floating point test busted #65

Closed Tux closed 9 years ago

Tux commented 9 years ago 
This is perl 5, version 22, subversion 0 (v5.22.0) built for x86_64-linux-thread-multi-ld
t/Spreadsheet/XLSX/Reader/51-percent_file_bug.t ................... 1/119
#   Failed test 'And check the returned value: 0.005'
#   at t/Spreadsheet/XLSX/Reader/51-percent_file_bug.t line 170.
#          got: '5E-03'
#     expected: '0.005'
# Looks like you failed 1 test of 119.
t/Spreadsheet/XLSX/Reader/51-percent_file_bug.t ................... Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/119 subtests
jandrew commented 9 years ago

I'll push this one to the top of the stack.

jandrew commented 9 years ago

This is tricky since the fail seems to be system dependant and CPAN Testers is down. I think I know where the variation is coming from but I will need to roll the change to github here for verification after I write it if you would be willing to test

Tux commented 9 years ago

of course

jandrew commented 9 years ago

Thanks

jandrew commented 9 years ago

I hope pull request #66 fixes this one. I will leave it open for comment since I don't have any internal verification tests for this one and CPAN Testers is down. (It makes you think when an open source resource that you rely on goes down.)

Tux commented 9 years ago

All tests pass in git checkout

This however broke Spreadsheet::Read's support

Spreadsheet-Read 503 > prove -vwb t/630_xlsx.t
t/630_xlsx.t .. # Parser: Spreadsheet::XLSX::Reader::LibXML-v0.38.12

ok 1 - Nonexistent file
ok 2 - Empty file
Can't locate object method "_merge_map" via package "WorksheetInstance" at /pro/3gl/CPAN/Spreadsheet-Read/blib/lib/Spreadsheet/Read.pm line 330.
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 255 just after 2.
Dubious, test returned 255 (wstat 65280, 0xff00)
All 2 subtests passed

Test Summary Report
-------------------
t/630_xlsx.t (Wstat: 65280 Tests: 2 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
Files=1, Tests=2,  1 wallclock secs ( 0.02 usr  0.00 sys +  0.84 cusr  0.04 csys =  0.90 CPU)
Result: FAIL
jandrew commented 9 years ago

ok let me look into that