search

jandrew / Spreadsheet-XLSX-Reader-LibXML

Read spreadsheet files with xlsx extentions
Other
4 stars 2 forks source link

unsafe handling of missing row span #78

Closed jandrew closed 9 years ago

jandrew commented 9 years ago

Submitted via email

Use of uninitialized value in split at /usr/lib/perl5/site_perl/5.20.2/Spreadsheet/XLSX/Reader/LibXML/XMLReader/WorksheetToRow.pm line 491.

$row_ref at line 491, and it was this:

$row_ref = $VAR1 = { 'customFormat' => '1', 'customHeight' => '1', 'ht' => '62.9294', 'list' => [ { 'cell_col' => 1, 'cell_row' => 1, 'cell_type' => 'Text', 'cell_xml_value' => 'Source System Code', 'r' => 'A1', 's' => '2' },

all the rest of the columns

               ],
      'r' => 1,
      's' => '1'
    };

No ->{spans}. Is that supposed to be just ->{s}

Thanks Todd

jandrew commented 9 years ago

Should be fixed in the release for v0.38.18 but no test added to the test suit so I will leave it open till then