search

janeczku / calibre-web

:books: Web app for browsing, reading and downloading eBooks stored in a Calibre database
GNU General Public License v3.0
12.56k stars 1.32k forks source link

Add configuration options for reverse proxy auth using environment variables #2943

Open max-tet opened 9 months ago

max-tet commented 9 months ago

Is your feature request related to a problem? Please describe. I'd like to offer calibre-web as an app on my product Portal. All apps should be accessible without visible login screen. Proxy auth is a good way to do it but I need it enabled right at installation. It seems like currently, it can only be enabled through the web UI as described here.

Describe the solution you'd like I suggest offering the following environment variables.

drizuid commented 7 months ago

Not the dev or anyone of importance, but just reading this insulted me. So, you have a paid product and you're asking the dev to make changes purely to suit your paid product, you provide no linked PR making the changes you've requested..

it's like me going to mcdonalds and saying, hey, i sell your fries, but my customers don't want salt, so i need you to stop putting salt on fries so i can resell them, thanks. (except you dont say thanks, you just demand)

max-tet commented 7 months ago

Hi @drizuid.

A few wrong assumptions you have there. Let me clarify and start with the most important one:

  1. I will compensate app devs for having their apps in my store. This is just getting started with the first few initial paying customers, no payouts yet, as I iron out the last few details. The goal is to have a win-win-win situation, not a parasitic one like you have been understanding it. Here is more information.

Aside from that,

  1. I've been posting feature requests like this to many projects that I would like to have in the store. (With none of that negative feedback afair.) It is unrealistic for me to learn each and every codebase enough to create a PR.
  2. A feature like this is useful in a lot of other hosting environments and often, there is already an existing feature request I just have to add my opinion to. So this is not for my exclusive benefit.

So to pick up your example: this is more like me having a McDonalds franchise where McDonalds profits from my sales and telling them that some of my customers don't want salt and having that option might improve sales for everyone's benefit. And also other franchises might benefit from it.

I hope that clears up any confusion.