janeczku / calibre-web

:books: Web app for browsing, reading and downloading eBooks stored in a Calibre database
GNU General Public License v3.0
13.13k stars 1.4k forks source link

Please do not hardcode copy other Python libraries #3181

Open C0rn3j opened 1 month ago

C0rn3j commented 1 month ago

This https://github.com/janeczku/calibre-web/commit/884f7666fa7d95d64bf2266f0d08b1a014b83ef7 commit takes https://github.com/JordanMilne/Advocate and instead of forking and putting it in requirements.txt, it hardcodes it into the code base.

Now, if any other project needs this dependency, they can't just take this maintained version, they have to roll their own, and there will be no collaboration possible.

Please do a fork as is custom (and as the previousmaintainer requested), package it and add it as a dependency to this project.

\~ Sincerely, someone who very recently spent a very large amount of time removing ancient integrated libraries from a project I took over, and I am not even done with it yet.

EDIT: I see this is not the only bundled library - https://github.com/janeczku/calibre-web/tree/master/cps/cw_login