[Feature request] magic login link QR code #781

janeczku / calibre-web

:books: Web app for browsing, reading and downloading eBooks stored in a Calibre database

GNU General Public License v3.0

13.13k stars 1.4k forks source link

[Feature request] magic login link QR code #781 #3203

Closed coissac closed 1 week ago

coissac commented 3 weeks ago

A proposition to implement the feature request #781 asking for a QR code on the magic login link page. As proposed, the solution is based on the qrcode python library and consists of modifications to two files:

cps/remotelogin.py: add code into the remote_login() function and imports conditionally the qrcode library
cps/templates/remote_login.html: change the template to display, if available, the QR code below the original link

The two other modified files are only to declare the dependency to the qrcode library

All the best

Eric

OzzieIsaacs commented 1 week ago

I see in the linked issue that I agreed at that time to implement the feature. 5 years have passed since then and I've become a lot wiser. I now have a contributing file and there I explained that I will not add another login method. I consider this an additional login method. I added up a lot of stuff in the past 5 year and some of it creates constantly trouble and don't want to have any more "non book related" issues.

So I'm sorry, but I will not merge it.

coissac commented 1 week ago

Five years ago, I did not use your soft. No problem for me if you didn't want to merge. I have my fork, which I'm now using as my reference version for my server. I just wanted to help your project. But you are the boss of your repository.

Cheers.

OzzieIsaacs commented 1 week ago

Thanks for the effort you put into it. Feel free to fork the software and use it as it fits best to your beeds