janeczku / haproxy-acme-validation-plugin

:four_leaf_clover: Zero-downtime ACME / Let's Encrypt certificate issuing for HAProxy
MIT License
291 stars 50 forks source link

conflict with /etc/cron.d/certbot? #12

Open RobT2012 opened 7 years ago

RobT2012 commented 7 years ago

According to the installation instructions, I should add a cron job as follows:

sudo crontab -e 5 8 6 /usr/bin/cert-renewal-haproxy.sh

The problem I see is /etc/cron.d/certbot (it is installed when installing certbot) renews the certs but will not regenerate the haproxy.pem files as required. If /etc/cron.d/certbot runs before cert-renewal-haproxy.sh, then the certs will already be renewed, and cert-renewal-haproxy.sh will fail to regenerate the haproxy.pem files.

I think that the install instructions should say that /etc/cron.d/certbot must be disabled if it has been installed.

Another minor issue is that "letsencrypt-auto" no loner exists, it should be renamed to "cerbot".