DNSimple lego function signature wrong leaks token

janeczku / rancher-letsencrypt

:cow: Rancher service that obtains and manages free SSL certificates from the Let's Encrypt CA

Apache License 2.0

326 stars 114 forks source link

DNSimple lego function signature wrong leaks token #93

Open jmatsushita opened 7 years ago

jmatsushita commented 7 years ago

I don't know if the API called changed for lego but currently it takes the OAUth token first and then the BaseURL second.

Given how this is being called right now by rancher-letsencrypt it tries to use the token as a base url and leaks it in the logs and I guess to the DNS servers too....

I'll post a PR.

Jun

cnf commented 5 years ago

I came here because I have the same issue.

I guess this project is just abandoned... too bad I can't find a decent alternative...