janehurh48 / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

Summary #4

Open Emik234 opened 6 years ago

Emik234 commented 6 years ago

Project name: Dasmoto's Arts & Crafts Grade: Meets Expectations

Summary: Good job completing this project and submitting it on time! You have learned to work locally in your text editor and that is a big step. Your file structure was well organized and your heading hierarchy was coherent.

Your project was tidy and well-formatted throughout. For a more in depth look at best practices, I recommend reading through this chapter: http://learn.shayhowe.com/html-css/writing-your-best-code/

For future projects, you may want to download all images and use relative paths to link to them rather than absolute paths. While this isn’t strictly necessary, I do encourage it as new developers often struggle with directory structure at first and this is an important concept to get right. For more info, please read this section: https://internetingishard.com/html-and-css/links-and-images/#absolute-relative-and-root-relative-links

Finally, I encourage you to start thinking about web accessibility. This is something you will learn more about in week 7 but for a quick overview: ​https://www.codecademy.com/articles/accessibility

Overall, you did an excellent job here. Keep up the hard work!

janehurh48 commented 6 years ago

Hi there! I thought that my images were linked using relative paths... Isn't "./resource" referencing a relative path rather than an absolute path since it is indicating a position relative to my index.html file? I just had a lot of confusion around linking images in particular so I want to make sure I'm understanding correctly. Thank you so much!!