search

janeklb / gh-search

GitHub code search with full text regex filtering, from your cli.
42 stars 3 forks source link

Better configuration management #3

Closed janeklb closed 2 years ago

janeklb commented 3 years ago

Give option to manage gh tokens and api urls in a local config file on the users file system, rather than relying on envars

yermulnik commented 2 years ago

Is there any progress on this?

janeklb commented 2 years ago

I have not made any progress, no. Wasn’t sure if there was appetite for it - envars have been working fine for me.

Are envars not suitable for you?

yermulnik commented 2 years ago

They are suitable but sort of less secure. I don't really want my GH Token to be set globally for the shell session via env just for a single app (gh-search) or to make sure I don't forget to set this envvar every time I want to use this great tool. Having this set via config file is more common, imho. Thanks

janeklb commented 2 years ago

Ah yes - the security aspect is a very important one. Thanks for calling it out. I will bump this issue up on my todo list (though to be transparent, it’s still not at the top).

It’s worth nothing that I’ve been less enthused to work on this tool (though I very much appreciate your comment!), ever since I found that GH is working on an improved search themselves: https://cs.github.com/

I suspect a gh update will follow too..

yermulnik commented 2 years ago

I will bump this issue up on my todo list (though to be transparent, it’s still not at the top).

Thanks a lot!

ever since I found that GH is working on an improved search themselves: https://cs.github.com/

This was basically how I came across gh-search and found it very convenient (thank you once again!). The https://cs.github.com/ redirects me to https://github.com/ =(

I suspect a gh update will follow too..

Who knows whether it's going to be as convenient and flexible as gh-search is =) Anyways I'll defo will keep using gh-search and will keep in my arsenal of great utilities!

janeklb commented 2 years ago

Released in 0.8.1 https://github.com/janeklb/gh-search/releases/tag/0.8.1 :)

@yermulnik please let me know how the general UX of this feature feels when you get a chance to try it out

yermulnik commented 2 years ago

yay! works great! thanks a lot!

yermulnik commented 2 years ago

@janeklb When you wrote "Released in 0.8.1", the first thing I did was gh-search --version, though this failed — what would you think of adding --version (https://click.palletsprojects.com/en/8.0.x/api/#click.version_option)? If this looks good to you, I'll create an issue for you to keep track of the request. Let me know.

janeklb commented 2 years ago

Yeah, why not :) feel free to raise an issue

On Mon, 7 Feb 2022 at 10:35, George L. Yermulnik @.***> wrote:

@janeklb https://github.com/janeklb When you wrote "Released in 0.8.1", the first thing I did was gh-search --version, though this failed — what would you think of adding --version ( https://click.palletsprojects.com/en/8.0.x/api/#click.version_option)? If this looks good to you, I'll created an issue for you to keep track of the request. Let me know.

— Reply to this email directly, view it on GitHub https://github.com/janeklb/gh-search/issues/3#issuecomment-1031317095, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGWGVEFCEHWFVI25TWFTXLUZ6N6TANCNFSM4V6NH6YQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

yermulnik commented 2 years ago

https://github.com/janeklb/gh-search/issues/58