janelia-flyem / NeuTu

Software package for neuron reconstruction and visualization
Other
38 stars 13 forks source link

Tip detection #352

Closed olbris closed 4 years ago

olbris commented 4 years ago

These changes are in support of Steve's new tip detection QC scheme.

First, added two columns to the to do table: tip index and tip RoI. This is unfortunately kind of ugly. When this tip QC workflow is run, Stuart will add two properties to a tip detector to do item, "tip qc index" and "tip qc roi". If they are present, they will be displayed in these two new columns in the table. The user can then sort and filter on them to review whether the tips have been correctly followed or whatever. The index is the order in which they should examine the tips. I don't like this because those columns are unused for all other to do items. Maybe later we will take them back out, after this task is done. I think all of this code is in ZFlyEmTodoPresenter.

Second change: in ZFlyEmProofDoc::setTodoItemChecked(), record the username and timestamp whenever a to do "checked" status is changed. Store them in two new properties on the to do item: "checked updated by" and "checked updated at". This will help Stuart measure how fast the user completes the task.

I'm on vacation next week, but hopefully these are straightforward changes that won't cause problems.

tingzhao commented 4 years ago

I'm wondering if it's better to to record todo status changes in Kafka instead of intrinsic properties. @stuarteberg

olbris commented 4 years ago

We talked about that...probably that is a better idea, but we didn't have anything set up, so this was the best I could do quickly. I am fine with alternatives so long as they meet Steve's time requirements.

tingzhao commented 4 years ago

OK. I'll merge it for now. BTW, it's quite easy to log kafka messages in NeuTu. Just call something like: KINFO << "message";