search

janelia-flyem / gala

Automatic segmentation of electron microscopy volumes
BSD 3-Clause "New" or "Revised" License
75 stars 29 forks source link

Include tests for image_type #93

Open JohnnyTeutonic opened 7 years ago

JohnnyTeutonic commented 7 years ago

Put in a test for the function 'viz.show_multiple_images' to ensure that the 'image_type' parameter has sane output

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.03%) to 50.195% when pulling aabfd532ab00991bbfe93cc91c3a115cb1949913 on JohnnyTeutonic:imshow into 7c80b30957bc7309a7c7bca5cfedf6f0f6b13b5d on janelia-flyem:master.

jni commented 6 years ago

@JohnnyTeutonic now you should add a test case that raises this error. =)

JohnnyTeutonic commented 6 years ago

weird build fail? Owing to: install_requires=INST_DEPENDENCIES, scripts=["bin/gala-segment", "bin/gala-segmentation-stitch", "bin/gala-segmentation-pipeline", "bin/gala-train", "bin/gala-test-package", "bin/gala-pixel", "bin/comparestacks", "bin/gala-valprob", "bin/gala-auto", "bin/gala-serve"],

in 'setup.py'.

very confused, as that environment variable is present in all your setup.py scripts

jni commented 6 years ago

Yes I've actually spent all of today fixing this in various packages, that's why I was even looking at the gala repo. =) setuptools v38 introduced a breaking change that install requirements could only be ordered containers (lists, tuples) and not unordered ones (sets) so that the order of package installation would be fixed. If you rebase on master you should see the error disappear.

JohnnyTeutonic commented 6 years ago

Ah that makes a hell of a lot of sense. I'll try and see if I can figure out how to rebase. What do you mean? I input the 'colour' parameter and that raised the LookupError?

On 12 Feb 2018 6:07 pm, "Juan Nunez-Iglesias" notifications@github.com wrote:

Yes I've actually spent all of today fixing this in various packages, that's why I was even looking at the gala repo. =) setuptools v38 introduced a breaking change that install requirements could only be ordered containers (lists, tuples) and not unordered ones (sets) so that the order of package installation would be fixed. If you rebase on master you should see the error disappear.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/janelia-flyem/gala/pull/93#issuecomment-364842377, or mute the thread https://github.com/notifications/unsubscribe-auth/AOIZLS145ORcYDlJ-siulSsQMGorV_m-ks5tT-NDgaJpZM4OHY0R .

JohnnyTeutonic commented 6 years ago

Ah I should rename my test function! That's why you think i haven't tested it.

On 12 Feb 2018 6:25 pm, "Jonathan Reich" jonathanreich100@gmail.com wrote:

Ah that makes a hell of a lot of sense. I'll try and see if I can figure out how to rebase. What do you mean? I input the 'colour' parameter and that raised the LookupError?

On 12 Feb 2018 6:07 pm, "Juan Nunez-Iglesias" notifications@github.com wrote:

Yes I've actually spent all of today fixing this in various packages, that's why I was even looking at the gala repo. =) setuptools v38 introduced a breaking change that install requirements could only be ordered containers (lists, tuples) and not unordered ones (sets) so that the order of package installation would be fixed. If you rebase on master you should see the error disappear.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/janelia-flyem/gala/pull/93#issuecomment-364842377, or mute the thread https://github.com/notifications/unsubscribe-auth/AOIZLS145ORcYDlJ-siulSsQMGorV_m-ks5tT-NDgaJpZM4OHY0R .