janengelmohr / android_device_elephone_p8000

Device repository for Elephone P8000
GNU General Public License v2.0
29 stars 52 forks source link

Merge Snap Camera into build chain #76

Closed janengelmohr closed 8 years ago

janengelmohr commented 8 years ago

It nearly works already with https://github.com/visi0nary/android_packages_apps_Snap but once a picture is taken, the preview freezes... Camera2 works fine though so I am sure the callback needs to be changed in the app.

janengelmohr commented 8 years ago
> E/MtkCam/Cam1Device(  274): (274)(Default:0)[Cam1DeviceBase::takePicture] CamAdapter->takePicture() returns: [Function not implemented(38)] (takePicture){#858:vendor/mediatek/proprietary/hardware/mtkcam/v1/device/Cam1DeviceBase.cpp}
> E/CAM_AndroidCameraManagerImpl( 5520): take picture failed.
> E/AndroidRuntime( 5520): FATAL EXCEPTION: Camera Handler Thread
> E/AndroidRuntime( 5520): Process: org.cyanogenmod.snap, PID: 5520
> E/AndroidRuntime( 5520): java.lang.RuntimeException: takePicture failed
> E/AndroidRuntime( 5520):  at android.hardware.Camera.native_takePicture(Native Method)
> E/AndroidRuntime( 5520):  at android.hardware.Camera.takePicture(Camera.java:1501)
> E/AndroidRuntime( 5520):  at com.android.camera.AndroidCameraManagerImpl$CameraHandler$1.run(AndroidCameraManagerImpl.java:165)
> E/AndroidRuntime( 5520):  at android.os.Handler.handleCallback(Handler.java:739)
> E/AndroidRuntime( 5520):  at android.os.Handler.dispatchMessage(Handler.java:95)
> E/AndroidRuntime( 5520):  at android.os.Looper.loop(Looper.java:135)
> E/AndroidRuntime( 5520):  at android.os.HandlerThread.run(HandlerThread.java:61)

This happened after pushing the "Take Picture" button again when the old image was shown.

valascus commented 8 years ago

If u select HDR, camera doesnt freeze

janengelmohr commented 8 years ago

Good finding, thank you!

janengelmohr commented 8 years ago

fixed with https://github.com/visi0nary/android_device_elephone_p8000/commit/a0971122e5248891c384649da916698ceec4b2a4