Closed mbacarella closed 2 years ago
@mbacarella, can you please sign-off your contribution as described in https://probot.github.io/apps/dco/?
@mbacarella, can you please sign-off your contribution as described in https://probot.github.io/apps/dco/?
I think adding a DCO will leave a big mess in the repo since I have the rebase in master in this PR. Do you know a clean way to do this, or should I just submit a new PR that's properly signed off?
You can git rebase the commits. E.g. you could use git rebase -i 02baffc343fd0eb8f58dce6fddf1ab5d3afba78e
(and only keep the meaningful commit in the resulting prompt).
Making a new PR is also fine.
Thank you!
cc @lpw25, given your involvement with Float_array
(which is not open-source (yet?)).
The standard library provides
Array.create_float
, though it does not appear re-exported inBase
.This is substantially faster than creating a float array using
Base
'sArray.create ~len 0.
, and also gives you the option of initializing it by yielding periodically to, say,Async
. This is very important for low-latency, realtime applications as it preventsAsync
from being blocked.This PR proposes exposing the stdlib
create_float
function, but with a more appropriate name:create_float_uninitialized
.A quick benchmark follows: