search

janestreet / base

Standard library for OCaml
MIT License
848 stars 124 forks source link

Windows compatibility #152

Closed db4 closed 1 year ago

db4 commented 1 year ago

v0.16 and up breaks Windows compatibility; fix that

hhugo commented 1 year ago

This has already (partially) been fixed in https://github.com/janestreet/base/commit/7ef8a32cf22b6584b843e00acbf5803c2b3803de part of the https://github.com/janestreet/base/tree/v0.16 branch and included in the v0.16.1 release.

That said, your fix looks much better/more idiomatic and should probably replace the current fix.

db4 commented 1 year ago

Sorry, I missed v0.16.1 release. As for the fix, the sources already contained https://github.com/janestreet/base/blob/041bbbba50cf25a35c14e7c042ba4fe33521851e/src/am_testing.c#L6 so I just did the same.

dkalinichenko-js commented 1 year ago

Thank you for the idiomatic fix! We'll release Base v0.16.2 with it included this week.