Closed ytrellu closed 4 years ago
I also considered the following:
Defining check_eq2_for_exn ~f name t1 t2
such that check_length2_exn = check_eq2_for_exn ~f:length
to have less duplication between the Array and List module. However this would have modified the module signature of either Array0 or List, which is a bigger change.
Running tests against array.ml and the modifs; but I could not get them to work :/. I did find the readthedocs for dune, and the ppx_inline_test package advertised on the contribute page, but it did not help me here unfortunately.
Thanks for the contribution! I've imported the patch into our internal repo for review.
Thanks! I noticed a small error in the commit, now amended.
closes #90