search

janestreet / bin_prot

Binary protocol generator
MIT License
73 stars 21 forks source link

Installation failure on FreeBSD #26

Closed avysk closed 1 month ago

avysk commented 3 months ago

See https://github.com/janestreet/bin_prot/blob/c29055692df839e3b10c776a78f7ba6ec4282e91/xen/cflags.sh#L1

/bin/bash does not exist on FreeBSD. If I install it from ports, it is /usr/local/bin/bash. The ln -s /usr/local/bin/bash /bin/bash workaround helps. Hardcoded paths are wrong.

michaelzappa-jhuapl commented 3 months ago

As well as on non-FHS Linux distributions.

aalekseyev commented 3 months ago

I'm changing it to run /usr/bin/env bash (on the internal repo, will make its way here eventually)

aalekseyev commented 3 months ago

Nvm, https://github.com/janestreet/bin_prot/pull/29 is clearly simpler :-)