janestreet / bin_prot

Binary protocol generator
MIT License
73 stars 21 forks source link

Remove hardcoded path to bash in shebang #31

Closed OlivierNicole closed 1 month ago

OlivierNicole commented 1 month ago

Such hardcoded path prevent to build and opam install bin_prot on platforms where bash is not at the expected location, such as NixOS. /usr/bin/env bash is the most portable shebang for UNIX-like systems.

aalekseyev commented 1 month ago

This is subsumed by https://github.com/janestreet/bin_prot/pull/29, which should be included in the next update of this package.

OlivierNicole commented 1 month ago

That’s good to know, thanks!