janestreet / magic-trace

magic-trace collects and displays high-resolution traces of what a process is doing
https://magic-trace.org
MIT License
4.52k stars 87 forks source link

Show call source in UI #249

Open Lamoreauxaj opened 1 year ago

Lamoreauxaj commented 1 year ago

For #212, this PR shows the source of each call in the args shown given we already have that information. Overall pretty simple, but I modified the calls to store where they were called from or whether it was unknown (thus also removing from_untraced). It shows the information as source_ followed by each of symbol, offset, and address as different args.

Lamoreauxaj commented 1 year ago

@Xyene This is from last week, but I just forgot to actually post the PR.

cgaebel commented 1 year ago

Hi Aaron. This looks great, but would you please fix the conflict before I merge it?