search

janestreet / magic-trace

magic-trace collects and displays high-resolution traces of what a process is doing
https://magic-trace.org
MIT License
4.52k stars 87 forks source link

Demangle OCaml symbols #250

Closed ClyveGassant closed 1 year ago

ClyveGassant commented 1 year ago

This addresses #82 by implementing the demangling parser from perf. I also included expect tests.

ClyveGassant commented 1 year ago

Thank you for the comments! I resolved them. I appreciate it.

hlian commented 1 year ago

@seliopou ready for review if you have free time!

Xyene commented 1 year ago

Could you please rebase to pick up https://github.com/janestreet/magic-trace/commit/ad91ae012f2691cd362286c4b07f273485dd2095, so we can kick off CI again?

ClyveGassant commented 1 year ago

@Xyene I completed your comment!