search

janestreet / magic-trace

magic-trace collects and displays high-resolution traces of what a process is doing
https://magic-trace.org
MIT License
4.58k stars 87 forks source link

Add support for jcmd Compiler.perfmap #298

Closed theothornhill closed 4 months ago

theothornhill commented 5 months ago

Even though the perf "spec" for jit languages define the perf map syntax, the jcmd Compiler.perfmap insists on prepending 0x to the addresses.

In addition, there's now a way for the jvm to generate the perfmap automatically on exit, making magic-trace run -multi-thread -snapshot-size 1M -- ./demo/java return something useful without messing around with perfmap generation. Add these options to the ./demo/java file

theothornhill commented 4 months ago

Ping! 😊

theothornhill commented 4 months ago

Thanks - I'll look at the formatting failure. Code was run using the examples from the readme. I'll check if that either needs amending or if I missed something.

theothornhill commented 4 months ago

I updated the .ocamlformat to 0.26.2. Do you want me to also update the relevant parts of the documentation?

Xyene commented 4 months ago

I've updated the docs, thanks!