Add inline_tests to test/dune

janestreet / ppx_custom_printf

Printf-style format-strings for user-defined string conversion

MIT License

23 stars 9 forks source link

Add inline_tests to test/dune #5

Closed ksromanov closed 4 years ago

ksromanov commented 5 years ago

According to dune documentation, test/dune should contain (inline_tests) stanza. Actually, without this stanza it does not run tests. Silently... Also, it worth to format it a bit. Final version:

(library 
 (name custom_printf_sample) 
 (inline_tests)
 (libraries ppx_sexp_conv.runtime-lib)
 (preprocess (pps ppx_jane)))

(alias (name DEFAULT) (deps test.ml.pp))

v-gb commented 4 years ago

For now, we don't currently setup tests anywhere in our public libraries. There are technical issues that need to be handled to make that work (test libraries are not explicitly annotated internally so we'd need to somehow change that, apparently opam install --with-test would run into dependency cycles, and presumably some of our tests wouldn't work outside our walls), which are being worked on, although I'm guessing it's going to take a while (certainly months).

So I'm going to close this because for now we don't really support running tests, but hopefully in the future, changes not specific to ppx_custom_printf will update the ppx_custom_printf tests to just work in the open source world.