search

janestreet / ppx_expect

Cram like framework for OCaml
MIT License
146 stars 28 forks source link

Exclude unnecessary unistd.h in MSVC #44

Closed jonahbeckford closed 1 year ago

jonahbeckford commented 1 year ago

Problem

Without the PR I get this failure (in v0.15.1):

#=== ERROR while compiling ppx_expect.v0.15.1 =================================#
# context     2.2.0~alpha0~20221104 | win32/x86_64 | conf-withdkml.2 ocaml-system.4.14.0 | https://opam.ocaml.org#da1c2a4d
# path        C:\Users\WDAGUtilityAccount\source\_opam\.opam-switch\build\ppx_expect.v0.15.1
# command     C:\Users\WDAGUT~1\AppData\Local\Programs\DISKUV~1\bin\WITH-D~1.EXE dune build -p ppx_expect -j 11
# exit-code   1
# env-file    C:\Users\WDAGUtilityAccount\AppData\Local\opam\log\ppx_expect-3148-90567f.env
# output-file C:\Users\WDAGUtilityAccount\AppData\Local\opam\log\ppx_expect-3148-90567f.out
### output ###
# File "collector/dune", line 5, characters 10-37:
# 5 |  (c_names expect_test_collector_stubs)
#               ^^^^^^^^^^^^^^^^^^^^^^^^^^^
# (cd _build/default/collector && C:\DiskuvOCaml\BuildTools\VC\Tools\MSVC\14.26.28801\bin\HostX64\x64\cl.exe -nologo -O2 -Gy- -MD -Z7 -D_CRT_SECURE_NO_DEPRECATE -nologo -O2 -Gy- -MD -Z7 -I C:/Users/WDAGUT~1/AppData/Local/Programs/DISKUV~1/lib/ocaml -I C:\Users\WDAGUtilityAccount\source\_opam\lib\base -I C:\Users\WDAGUtilityAccount\source\_opam\lib\base\base_internalhash_types -I C:\Users\WDAGUt[...]
# expect_test_collector_stubs.c
# expect_test_collector_stubs.c(5): fatal error C1083: Cannot open include file: 'unistd.h': No such file or directory

Solution

unistd.h is not present and usually not necessary in MSVC