search

janestreet / ppx_optcomp

Optional compilation for OCaml
MIT License
65 stars 18 forks source link

Expose os_type #10

Closed Et7f3 closed 4 years ago

Et7f3 commented 4 years ago

Allow to test on os_type. In Revery we need to add some variant/code depending on the OS. and this will help. I have done 2 commit the first one is very lightweight and don't bring new dependencies. The second one bring unix dependencies to produce better variable. I can remove last commit.

Force push is just for the DCO bot. I have used unix and not core because for one function ... I think it is overkill.

Also sorry for formatting but their is no .ocamlformat file.

lpw25 commented 4 years ago

I've released the first commit internally, it should show up in a few days. I decided to leave out the second commit: I think we'd rather avoid calling out to another process.

Et7f3 commented 4 years ago

ragh first commit lost author information https://github.com/janestreet/ppx_optcomp/commit/7b4c6048af50a89d44fdb8f4a8eabb98ed4e6a8a :cry: