search

janestreet / ppx_optcomp

Optional compilation for OCaml
MIT License
65 stars 18 forks source link

Use `Parser` module from compiler-libs #14

Closed pitag-ha closed 3 years ago

pitag-ha commented 3 years ago

Ppxlib is making Parser.token abstract and therefore breaks the current implementation of Cparser. Other uses of Ppxlib.Parser are also replaced by the compiler-libs Parser both for consistency and because Ppxlib is likely going to remove Parser from its API.

pitag-ha commented 3 years ago

@cwong-ocaml, would you mind releasing this?

pitag-ha commented 3 years ago

Is there anything blocking the PR from being merged? I'm asking because having this change released would be important to avoid a conflict between ppx_optcomp and ppxlib.

cwong-ocaml commented 3 years ago

Sorry, it got buried in my todo.

pitag-ha commented 3 years ago

Thanks for merging and releasing this! Is the release also published on opam? I can't find it there.

cwong-ocaml commented 3 years ago

I believe it just got merged.

pitag-ha commented 3 years ago

Oh ok, perfect! Thanks!