search

janestreet / ppx_optcomp

Optional compilation for OCaml
MIT License
65 stars 18 forks source link

Request: ppx_optcomp to support reading environment variables at compile time #8

Open tomjridge opened 5 years ago

tomjridge commented 5 years ago

Hi,

Related discussion:

https://discuss.ocaml.org/t/ppx-getenv-dune-compatible-alternative/4082

It would be useful if I could control the compilation via an environment variable, similar to the ppx_getenv example by whitequark (which doesn't work with dune).

Are there plans to add this?

Thanks!

trefis commented 5 years ago

There aren't any plans to add this feature no, but on principal I don't see any reason to object to it. So if you want to submit a PR we will have a look at it.