janestreet / ppxlib_jane

Utilities for working with Jane Street AST constructs
MIT License
5 stars 4 forks source link

Location.errorf printers expect Format_doc formatter but existing pretty printers come from Format #3

Open wokalski opened 1 week ago

wokalski commented 1 week ago

I was compiling ppxlib_jane against ocaml 5.3 with the latest ppxlib and it didn't compile because of the discrepancies in the formatting types.

I don't know what's the correct solution (I ended up hacking around it quickly). Here's some related discussion https://github.com/ocaml-ppx/ppxlib/pull/487. I've also seen Format_doc.deprecated_printer which I believe built for this.