search

janestreet / sexplib

Automated S-expression conversion
MIT License
147 stars 27 forks source link

Sexplib.Conv support for Bytes? #15

Closed avsm closed 6 years ago

avsm commented 9 years ago

Right now using Bytes.t results in a Error: Unbound value Bytes.t_of_sexp. Would it be possible to add a converter for this to assist with safe-string migration from String.t_of_sexp?

ghost commented 9 years ago

This should be OK. Note that this is not yet released but we added this to Core_kernel.Std until we enable safe-string:

type bytes =
  [ `This_type_does_not_equal_string_because_we_want_type_errors_to_say_string ]

Bytes.t is not diverted though.

hhugo commented 6 years ago

should be fixed.