search

janestreet / sexplib

Automated S-expression conversion
MIT License
147 stars 27 forks source link

sexplib requirement of ocaml-version >= "4.06.0" in opam #32

Closed ghost closed 7 years ago

ghost commented 7 years ago

The new version of sexplib v.0.9.3 requires OCaml version at least 4.06.0 (https://opam.ocaml.org/packages/sexplib/sexplib.v0.9.3/), and the new base v.0.9.4 requires sexplib v.0.9.3 (https://opam.ocaml.org/packages/base/base.v0.9.4/), although the base has ocaml-version >= "4.03.0" requirement, and the base is part of other libraries (core and etc.). Is it possible to have lower requirement for the new sexplib, for example ocaml-version >= "4.05.0" (or >= 4.03.0 as for the base)?

xclerc commented 7 years ago

After some testing, it seems to be fine to relax the lower bound to 4.04.2 (see https://github.com/ocaml/opam-repository/pull/10657)

ghost commented 7 years ago

Thank you, xclerc.

ghost commented 7 years ago

It seems the build fails for 4.04.2, but it is fine with 4.05.0. Maybe due to this change https://github.com/ocaml/ocaml/pull/875? 4.05.0 as a lower bound would be fine as well.

xclerc commented 7 years ago

No, it is due to me performing the tests on the wrong branch... The correct lower bound is indeed 4.05.0, I have just updated the opam PR.