Use bigarray-compat instead bigarray to avoid a link with unix

janestreet / sexplib

Automated S-expression conversion

MIT License

147 stars 27 forks source link

Use bigarray-compat instead bigarray to avoid a link with unix #40

Closed dinosaure closed 3 years ago

dinosaure commented 4 years ago

According OCaml version needed by sexplib and needed bigarray library, this PR provides a compatible way to depend only on Stdlib.Bigarray (without map_file and UNIX syscall) and be able to integrate sexplib into a MirageOS unikernel (where unix.cmxa is forbidden).

aalekseyev commented 3 years ago

My understanding is that post-4.07 bigarray-compat is merely forwarding to Stdlib.Bigarray. Sexplib now depends on ocaml >= 4.08, so it seems that this PR does nothing (anymore?). I don't really understand where this is related to unix, either.

I'm closing the PR, assuming it's no longer relevant. Please reopen if you disagree.