search

janestreet / time_now

Reports the current time
MIT License
7 stars 7 forks source link

Dropped MSVC support #3

Open jonahbeckford opened 1 year ago

jonahbeckford commented 1 year ago

There was commit https://github.com/janestreet/time_now/commit/3d2ce1bd05dc5badf59458fd1e89bfa2d13556e7 that supported the MSVC compiler. But it got removed.

As a temporary hack, for Windows users of Diskuv OCaml (DKML) I've patched this package in the DKML opam repository.

jonahbeckford commented 1 year ago

One related MSVC note. During the build I get:

cl : Command line warning D9002 : ignoring unknown option '-std=c11'
cl : Command line warning D9002 : ignoring unknown option '-fPIC'

I am using MSVC 2019, where it just warns but does not fail the compilation. Often newer versions of MSVC will fail when a warning has been repeated long enough.