search

janet-lang / janet

A dynamic language and bytecode vm
https://janet-lang.org
MIT License
3.52k stars 227 forks source link

More portable method of installing janet.h -> janet/janet.h symlink #1164

Closed dressupgeekout closed 1 year ago

dressupgeekout commented 1 year ago

The problem that #994 was trying to solve (the symlink should be a relative path and not absolute) doesn't actually require the use of the GNU-only -t/-T option to ln(1).

sogaiu commented 1 year ago

To spell things out a bit...

The original proposed change looks like it was [1]:

ln -sf -t '$(DESTDIR)$(INCLUDEDIR)' janet.h janet/janet.h

What's currently in the Makefile is:

ln -sf -T ./janet/janet.h '$(DESTDIR)$(INCLUDEDIR)/janet.h' || true #fixme bsd

So it looks like there was a change to the original at some point.

Doing some digging, came across this.

Perhaps @shassard and/or @LeviSchuck would be interested in this topic.

[1] Which did get committed.