Closed sogaiu closed 1 year ago
This PR contains a suggestion to use vm_commit(); in place of janet_stack_frame(stack)->pc = pc;.
vm_commit();
janet_stack_frame(stack)->pc = pc;
The vm_commit(); construct is used elsewhere within the JOP_CALL handling in which this instance of janet_stack_frame(stack)->pc = pc; appears:
JOP_CALL
Perhaps it makes sense to use vm_commit(); on line 983 as well?
Though I can see that if one wanted to leave the JANET_FUNCTION-handling parts of JOP_CALL and JOP_TAILCALL easier to compare, perhaps not using vm_commit(); might be preferrable.
JANET_FUNCTION
JOP_TAILCALL
LGTM
This PR contains a suggestion to use
vm_commit();
in place ofjanet_stack_frame(stack)->pc = pc;
.The
vm_commit();
construct is used elsewhere within theJOP_CALL
handling in which this instance ofjanet_stack_frame(stack)->pc = pc;
appears:Perhaps it makes sense to use
vm_commit();
on line 983 as well?Though I can see that if one wanted to leave the
JANET_FUNCTION
-handling parts ofJOP_CALL
andJOP_TAILCALL
easier to compare, perhaps not usingvm_commit();
might be preferrable.