search

janet-lang / janet

A dynamic language and bytecode vm
https://janet-lang.org
MIT License
3.45k stars 223 forks source link

Treating MinGW as equivalent to an OS #1202

Closed pyrmont closed 1 year ago

pyrmont commented 1 year ago

One of the GitHub workflows run during CI is to build and test Janet using MinGW running in Wine on Linux (courtesy of #1141). This is causing a test I wrote for #1201 to fail because MinGW on Windows recognises NUL but MinGW in Wine on Linux recognises /dev/null. (Or at least I think that's what's happening. I don't have a Windows system so can't investigate this easily.)

My question is if the behaviour of MinGW changes depending on the underlying OS, should os/which return :mingw?

pyrmont commented 1 year ago

Thanks to @sogaiu, I realised the problem was in my test. I've fixed the test and no longer believe there is an issue.