janet-lang / janet

A dynamic language and bytecode vm
https://janet-lang.org
MIT License
3.43k stars 221 forks source link

Rework `reverse`, again #1252

Closed primo-ppcg closed 1 year ago

primo-ppcg commented 1 year ago

Related: #1248

With feedback from @bakpakin.

before:

> (reverse [:a :b :c])
@[:c :b :a]
> (reverse "abc")
@[99 98 97]
> (reverse {1 2 3 4 5 6})
@[nil 2 nil]

after:

> (reverse [:a :b :c])
@[:c :b :a]
> (reverse "abc")
@"cba"
> (reverse {1 2 3 4 5 6})
@[6 4 2]
primo-ppcg commented 1 year ago

I neglected to update the docstring.