search

janet-lang / janet

A dynamic language and bytecode vm
https://janet-lang.org
MIT License
3.43k stars 221 forks source link

Remove old parser code #1282

Closed sogaiu closed 11 months ago

sogaiu commented 11 months ago

This PR contains the removal of a line that looks obsolete.

I think the oldest version of the line in question is here. AFAICT the code has evolved since that time in such a way such that the line no longer appears necessary.

I ran various tests without detecting problems and failed to turn up any issues working at the REPL.

Perhaps I've missed something though (^^;

sogaiu commented 11 months ago

Actually, it looks like there is a difference in behavior:

$ ./build/janet
Janet 1.30.0-037e8288 linux/x64/gcc - '(doc)' for help
repl:1:> (def @ 1)
1
repl:2:> @
repl:3:0: parse error: symbol literal cannot start with a digit

VS

$ janet
Janet 1.30.0-51c0cf97 linux/x64/gcc - '(doc)' for help
repl:1:> (def @ 1)
1
repl:2:> @
1
sogaiu commented 11 months ago

There are some tests to check that symbols with @ in them work, but they somehow didn't catch the incorrect change made in this PR.