janet-lang / janet

A dynamic language and bytecode vm
https://janet-lang.org
MIT License
3.38k stars 217 forks source link

`default-peg-grammar` lacks `*` and `+` versions of `:A`, `:D`, `:H`, `:S`, and `:W` #1312

Closed sogaiu closed 9 months ago

sogaiu commented 9 months ago

Unlike :a, :d, :h, :s, and :w, the "capitalized" versions (negations - e.g. :A) in default-peg-grammar lack * and + versions:

https://github.com/janet-lang/janet/blob/cc5beda0d26c0b91fb28540291e950392cf59fc4/src/boot/boot.janet#L2333-L2355

I suspect that on some occasions some of us have missed :S+ or similar.

May be it makes sense to "complete" the set?

bakpakin commented 9 months ago

Looks fine to me

sogaiu commented 9 months ago

Thanks for the merge!