`make install` does not respect PREFIX

tekknolagi commented 5 years ago

It looks like make install does not respect the PREFIX, particularly when installing the man page to /usr/local/... and tools to JANET_PATH. This is not ideal; I'd like to have an installation of Janet in my ~/.local folder.

bakpakin commented 5 years ago

I have just pushed a fix that should help with that in the latest commit d2d502b9ae9e22c397f73b4af708b574d075e592 and its parent 3aae52496459240547a15833e3e406045f2f66b5. It also removes the automatic installation of the shared library libjanet.so as well, as that is by nature less portable and not needed to run janet.

bakpakin commented 5 years ago

The correct default JANET_PATH should now also set a build time as of 540b326c547e05a780358717c54f90aca9f543f3. Hopefully this should fix the problem.

bakpakin commented 5 years ago

Sorry about this whole issue, JANET_PATH was not being read at runtime at all, and the documentation in the man page was out of date. This was because the core library up until recently was basically evaled every time the janet binary was run - there was no bootstrapping step.

I have been working on some updates to this and made the following changes:

Setting PREFIX or JANET_PATH at build time will set the default JANET_PATH. This should make local installs work better out of the box.
Setting JANET_PATH on the command line via something like JANET_PATH=examples janet should work correctly. Something like JANET_PATH=examples build/janet -l colors should load the colors module.
The -m flag has been added as well, which does basically the same thing as setting JANET_PATH
Update the man page and changelog to reflect these changes

tekknolagi commented 5 years ago

Wow, thank you for your quick and comprehensive fix!

On Mon, Feb 18, 2019, 12:44 Calvin Rose notifications@github.com wrote:

Closed #44 https://github.com/janet-lang/janet/issues/44.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/janet-lang/janet/issues/44#event-2147222065, or mute the thread https://github.com/notifications/unsubscribe-auth/AAYfDzEbbnB-nJZmXXju9BrT2avBncB5ks5vOxCVgaJpZM4bBa5D .

janet-lang / janet

`make install` does not respect PREFIX #44