janet-lang / jpm

Janet Project Manager
MIT License
68 stars 22 forks source link

Don't require tags for inclusion in lockfile #29

Closed Jakski closed 2 years ago

Jakski commented 2 years ago

Currently jpm can prevent some dependencies from being included in lockfile, e.g:

(declare-project
  :name "project1"
  :description "project1"
  :dependencies [
                 {:url "https://github.com/Jakski/http/archive/20c1787177243c213c0aafd37bf41eb3cfe30c83.tar.gz"
                  :type :tar}])
$ rm -rf jpm_tree/ lockfile.jdn
$ jpm -l deps
...
$ jpm -l make-lockfile
Cannot add local or malformed package /opt/jpm_tree/lib/.manifests/http.jdn to lockfile, skipping...
created lockfile.jdn

Lockfile resulting from above command won't actually install all dependencies with load-lockfile. It makes lockfiles useless while working with tar archives, because it's still required to run jpm deps in order to get project working.

bakpakin commented 2 years ago

LGTM