janet-lang / jpm

Janet Project Manager
MIT License
72 stars 22 forks source link

Allow spaces in shell executables #33

Closed greenfork closed 3 years ago

greenfork commented 3 years ago

Closes #28

bakpakin commented 3 years ago

I get why you want to add this but it is a bit awful. At least add a comment explaining why this is there and then we can merge it.

greenfork commented 3 years ago

I share your sentiment, this is awful. There are some alternatives I have considered:

I'm not in a hurry to merge this and I'm open to suggestions. For now I added the comment you asked and feel free to merge it if you think this is good enough.

bakpakin commented 3 years ago

I'm pretty sure this is fine, I can't imagine any sane, informed person putting spaces in the name of a binary, but we should at least add a comment why this is being done.

greenfork commented 3 years ago

Thanks!