search

janet-lang / jpm

Janet Project Manager
MIT License
65 stars 21 forks source link

commands/set-tree: checks if on windows, if so use \ instead of / #48

Closed saikyun closed 2 years ago

saikyun commented 2 years ago

On windows using jpm -l deps I got errors about "Invalid switch /i". After investigation I found that set-tree didn't take windows into account, so I amended that. Now I am able to use jpm -l. :)

sogaiu commented 2 years ago

May be related a bit to #45.

bakpakin commented 2 years ago

So one reason I haven't been bullish on this is that modern windows should be able to use "/" in most (all?) scenarios - with the exception of shelling out to certain paths. So please let me know if this is is actually broken or "it just looks more windowsy".

sogaiu commented 2 years ago

Before #45 was merged I experienced breakage (running jpm -l deps in the cross subdirectory of https://github.com/saikyun/jaylib-wasm-demo (around 83eca893ff73fb9e54a8d9d744392927157a3cc9)).

I just tried with a version of jpm that had #45 merged and I don't see the same problems any more.

May be @saikyun can confirm.

saikyun commented 2 years ago

I had the same problem as sogaiu. For some time I've been seeing errors like "Invalid switch /i" when building, but it hasn't hindered building. However when using jpm -l and (janet-bounded-queue)[https://github.com/saikyun/janet-bounded-queue], the builds would fail (it couldn't find janet-bounded-queue). Only thing I can see is different about janet-bounded-queue is that it's a single file.

After using Janet built with this PR all errors disappeared.

saikyun commented 2 years ago

I didn't realize sogaiu mentioned a different PR, gonna have to try that one.

saikyun commented 2 years ago

Thanks!

Den lör 9 apr. 2022 19:01Calvin Rose @.***> skrev:

Merged #48 https://github.com/janet-lang/jpm/pull/48 into master.

— Reply to this email directly, view it on GitHub https://github.com/janet-lang/jpm/pull/48#event-6401989223, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAS46Z3V2CXXX4FVID6GMBLVEGZU3ANCNFSM5SR4KQDQ . You are receiving this because you were mentioned.Message ID: @.***>

saikyun commented 1 year ago

I had the same problem as sogaiu. For some time I've been seeing errors like "invalid switch /i", but it hasn't hindered building before I started using janet-bounded-queue and jpm -l. No clue why though, other than it being a single file library.

Either way, this PR removes the errors and lets me build with -l.