search

janet-lang / jpm

Janet Project Manager
MIT License
72 stars 22 forks source link

Recent work for mingw breaks linux #65

Closed LeviSchuck closed 1 year ago

LeviSchuck commented 1 year ago

Commit 3c77ccffd915fb07ea6a198f5602b6da202bd2a6 introduced 

(when-let [import-lib (dyn:janet-importlib)]
    (array/push dep-importlibs import-lib))

However this dyn appears only to be set on windows or mingw environments.

This results in stack traces such as the following during build on a linux docker container:

error: no value found for dynamic binding :janet-importlib
  in errorf [boot.janet] (tailcall) on line 171, column 3
  in link-c [/usr/local/lib/janet/jpm/cc.janet] on line 112, column 25
  in declare-native [/usr/local/lib/janet/jpm/declare.janet] on line 90, column 3
  in _thunk [./project.janet] (tailcall) on line 36, column 1
LeviSchuck commented 1 year ago

Thank you for the fix! I confirm that a522462e0808aa9d1815711b40bee7518bf6e184 resolves the issue.