janet-lang / jpm

Janet Project Manager
MIT License
72 stars 22 forks source link

Build on Ubuntu (WSL fails) #89

Open zuluonezero opened 6 months ago

zuluonezero commented 6 months ago
=:) sudo jpm build compiling raylib/src/rshapes.c to build/raylibsrcrshapes.o... compiling src/main.c to build/srcmain.o... compiling raylib/src/rcore.c to build/raylibsrcrcore.o... compiling raylib/src/rmodels.c to build/raylibsrcrmodels.o... compiling raylib/src/raudio.c to build/raylibsrcraudio.o... compiling raylib/src/rglfw.c to build/raylibsrcrglfw.o... compiling raylib/src/rtext.c to build/raylibsrcrtext.o... compiling raylib/src/rtextures.c to build/raylibsrcrtextures.o... compiling raylib/src/utils.c to build/raylibsrc___utils.o... generating meta file build/jaylib.meta.janet... raylib/src/rtextures.c:152: warning: "STB_IMAGE_IMPLEMENTATION" redefined 152 #define STB_IMAGE_IMPLEMENTATION
: note: this is the location of the previous definition In file included from src/main.c:5: src/types.h:483:20: error: expected expression before ‘,’ token 483 | JANET_ATEND_GET, Resolved by removing the trailing comma on line 483 in src/types.h
sogaiu commented 6 months ago

That does look like a problem.

I reproduced the issue. Removing the trailing comma as suggested did result in a successful build.

May be it would be better to report this to the jaylib repository though.

sogaiu commented 6 months ago

@zuluonezero

I've gone ahead an created an issue at the jaylib repository.

Thanks for reporting.

sogaiu commented 6 months ago

I believe the issue has been addressed in this commit.