search

janet-lang / path

Path manipulation library for Janet
MIT License
11 stars 4 forks source link

module/loading appears unused #3

Closed andrewchambers closed 4 years ago

andrewchambers commented 4 years ago

Sorry if this is a mistake on my part:

[ac@black:~/src/janet]$ git grep "module/loading"
src/boot/boot.janet:(def module/loading
src/boot/boot.janet:              (put module/loading path true)
src/boot/boot.janet:              (put module/loading path nil)

This table appears to serve no purpose.

bakpakin commented 4 years ago

This is for detecting circular dependencies. One could argue that it doesn’t need to be exposed, but it does not hurt.

bakpakin commented 4 years ago

Also, wrong repo?

bakpakin commented 4 years ago

Also, wrong repo?

andrewchambers commented 4 years ago

Im confused, how does it it detect circular dependencies if it is never used?

andrewchambers commented 4 years ago

Oh sorry wrong repo.